feat: implemented stable image shrink #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nd0ut
reviewed
Feb 12, 2024
| // Path: packages/image-shrink/src/helper | ||
| export { memoize, memoKeySerializer } from './helper/memoize' | ||
|
|
||
| export { shrinkFile, type TSetting } from './utils/shrinkFile' |
There was a problem hiding this comment.
I think the only thing we should export is this one.
nd0ut
reviewed
Feb 12, 2024
| @@ -0,0 +1,4 @@ | |||
| export const allowLayers = [ | |||
There was a problem hiding this comment.
There is a typo in the folder name (constans)
nd0ut
reviewed
Feb 14, 2024
| } | ||
|
|
||
| const squareSupported = await squareTest(testSquareSide, testSquareSide) | ||
| const dimensionSupported = await dimensionTest(testDimension, 1) |
There was a problem hiding this comment.
Probably it's better to use Promise.all here
nd0ut
reviewed
Feb 15, 2024
|
|
||
| return isTestPass | ||
| } catch (e) { | ||
| new Error(`Failed to test for max canvas size of ${width}x${height}.`) |
There was a problem hiding this comment.
The error isn't throwed or returned. Probably it should be console.log or console.error
nd0ut
reviewed
Feb 15, 2024
| return new Promise((resolve, reject) => { | ||
| replaceIccProfile(inputFile, []) | ||
| .then((file: Blob) => { | ||
| console.log({ file }, typeof file) |
nd0ut
reviewed
Feb 15, 2024
| image: File | Blob | string | ||
| ): Promise<HTMLImageElement> => { | ||
| if (image.src) { | ||
| return processImage(image) |
nd0ut
reviewed
Feb 15, 2024
| import { imageLoader } from '../image/imageLoader' | ||
|
|
||
| export const stripIccProfile = (inputFile: File): Promise<HTMLImageElement> => { | ||
| return new Promise((resolve, reject) => { |
nd0ut
approved these changes
Feb 15, 2024
added 6 commits
February 15, 2024 12:59
egordidenko
force-pushed
the
feature/implement-image-shrink
branch
from
e5322b6 to
de4850d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist